Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DS can (potentially) leak info by number of inputs #558

Closed
wants to merge 1 commit into from
Closed

DS can (potentially) leak info by number of inputs #558

wants to merge 1 commit into from

Conversation

UdjinM6
Copy link

@UdjinM6 UdjinM6 commented Aug 22, 2015

When users submit different number of inputs in one mixing session it can potentially leak info by previous txid even if all inputs use the same denomination(s). This is mostly applicable to first few rounds of mixing, the more rounds of mixing is passed the less info is leaked. But anyway, this is still a really bad situation imo.

This PR should fix issue I just described by requiring users to submit not only the same denominations but also exactly the same number of inputs.

Note:

  • replaces few value checks (which doesn't make sense together with this PR anymore imo) by "number of inputs" checks.
  • bumps PROTOCOL_VERSION and MIN_POOL_PEER_PROTO_VERSION

@UdjinM6 UdjinM6 added this to the 12.1 milestone Aug 22, 2015
@UdjinM6 UdjinM6 closed this Aug 22, 2015
@UdjinM6 UdjinM6 removed this from the 12.1 milestone Aug 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant